Tree Transform passing all tests, plus abuse

Aaron Bentley aaron.bentley at utoronto.ca
Sat Feb 11 20:04:21 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
| Aaron Bentley пишет:
|
|> John A Meinel wrote:
|> | Internally you use "os.path.join" rather than "osutils.pathjoin". Which
|> | means we would end up with '\' separated paths.
|>
|> Is that a problem?  This is all local fs stuff.
|
|
| Yes, I think it could create a problem.

It seemed to me that using non-native pathname separators as arguments
to filesystem manipulation commands was more likely to create problems.

| Bzr nick command also use local
| fs stuff but without proper path names manipulation it does not work
| properly on win32.

No, it doesn't:
~    return cfg.get_option(u"nickname", default=self.base.split('/')[-2])

It's the value of Branch.base that's incorrect in this regard.  It's
specified to be a URL.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD7kNF0F+nu1YWqI0RApX7AJ9C6PCoiGV/gOp8wIYjXNRx7fjaUgCePQxT
5lHzeRbvdMImFFvz631HcGs=
=mPzg
-----END PGP SIGNATURE-----




More information about the bazaar mailing list