[patch] Small refactoring in test suite.

Robert Collins robertc at robertcollins.net
Sun Feb 5 20:23:03 GMT 2006


On Sun, 2006-02-05 at 18:29 +0100, Jan Hudec wrote:
> Hello folks,
> 
> Would someone be willing to integrate following trivial fix to make things
> more pretty?
> 
> (note: I'll probably include it in the glob branch if neither accepted nor
> vetoed)
> 
> Thanks,
> 
> Jan
> 
> === modified file 'bzrlib/tests/__init__.py'
> --- bzrlib/tests/__init__.py	
> +++ bzrlib/tests/__init__.py	
> @@ -285,7 +285,7 @@
>              raise AssertionError('pattern "%s" not found in "%s"'
>                      % (needle_re, haystack))
>  
> -    def AssertSubset(self, sublist, superlist):
> +    def assertSubset(self, sublist, superlist):
>          """Assert that every entry in sublist is present in superlist."""
>          missing = []
>          for entry in sublist:


method names in the test suite are camelCased, not CapitalCased. We use
this as its consistent with pyunit, the test framework we are using.

I can't see any other changes in this patch, so -1.


Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060206/c44d6349/attachment.pgp 


More information about the bazaar mailing list