Any incompatibilities between 0.6.2 and 0.7 releases?

[Martin Pool]

On 26 Jan 2006, John A Meinel <john at arbash-meinel.com> wrote:
> It would be really nice if I could get a review of the rest of my
> jam-pending branch. (the Makefile fix, and the better error when missing
> an editor)

If it's just those two then +1 from me.

> === modified file 'Makefile'
> --- Makefile
> +++ Makefile
> @@ -10,8 +10,7 @@
> 
>  clean:
>         ./setup.py clean
> -       -find . -name "*.pyc" | xargs rm
> -       -find . -name "*.pyo" | xargs rm
> +       -find . -name "*.pyc" -o -name "*.pyo" | xargs rm -f
>         rm -rf test????.tmp
> 
>  .PHONY: all

I don't object to the change but won't it still fail if there are no
bytecode files?

Perhaps just 

  -find . -name '*.py[co]' -exec rm {} \;

> 
> === modified file 'bzrlib/msgeditor.py'
> --- bzrlib/msgeditor.py
> +++ bzrlib/msgeditor.py
> @@ -20,6 +20,7 @@
>  """Commit message editor support."""
> 
>  import os
> +import errno
>  from subprocess import call
> 
>  import bzrlib.config as config
> @@ -51,7 +52,13 @@
>      """Try to execute an editor to edit the commit message."""
>      for e in _get_editor():
>          edargs = e.split(' ')
> -        x = call(edargs + [filename])
> +        try:
> +            x = call(edargs + [filename])
> +        except OSError, e:
> +           # ENOENT means no such editor
> +           if e.errno == errno.ENOENT:
> +               continue
> +           raise
>          if x == 0:
>              return True
>          elif x == 127:

+1

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060130/9d38a9c6/attachment.pgp