selftest should continue after skip even if --one

Robert Collins robertc at robertcollins.net
Thu Jan 26 21:25:51 GMT 2006


On Thu, 2006-01-26 at 11:45 -0600, John A Meinel wrote:
> Robert brought up this bug a while ago, I decided to fix it, and the fix
> is in my 'jam-pending' branch revno:1511
> 
> Basically, the problem was that EarlyStoppingAdapter was being wrapped
> around _MyResult, which was causing _result.stop() to be called, before
> _MyResult could realize that it was a SKIP.
> 
> I realized that since we use _MyResult anyway, we don't really need the
> EarlyStopping adapter. I don't know if we would want it for other front
> ends, but I don't know that other front ends would support the stop
> early request anyway.
> 
> So attached is the patch which fixes it.
> 
> Aaron, can you review my jam-pending branch? I put the paramiko fix in
> there as well.

FWIW its already fixed in branch-formats.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060127/f50e9dd0/attachment.pgp 


More information about the bazaar mailing list