[rfc] [patch] sftp unit tests without ssh

[Robey Pointer]

On 24 Jan 2006, at 12:00, John Arbash Meinel wrote:

> However, after merging you I get:
> ~bzr: WARNING: Exception from within unit test server thread:
> <socket.error instance at 0xb6b6894c>
> ~bzr: WARNING: Exception from within unit test server thread:
> <socket.error instance at 0xb6b68bac>
> ~bzr: WARNING: Exception from within unit test server thread:
> <socket.error instance at 0xb6b6582c>
>
> Probably we should also us 'log_exception_quietly()' which puts a
> traceback into ~/.bzr.log, which would help debug this.

I see these sometimes, though I can't reproduce them right now  
(probably laptop slowness).  log_exception_quietly() won't help much,  
because the logs are erased right after each test, so you'll never  
see the exception. :)

I think the error is just a shutdown synchronization problem: one  
side closing before the other is finished.  Probably the unit test's  
destructors abruptly closing sockets that the server thinks are still  
in play -- which is why the don't cause the test to fail.  Maybe we  
should just catch and squelch socket.errors, but I wish I could catch  
one in the act just to make sure.

robey