Weave.join(), and progress indicator fixes

John A Meinel john at arbash-meinel.com
Wed Jan 25 18:06:19 GMT 2006


I fixed the Weave.join() to use the optimized path, along with a test to
make sure texts are unnecessarily extracted.
I also fixed the Weave.join() so it doesn't need to reweave if it comes
across another weave with parents re-ordered, or with repeat parents.

While I was there, I fixed up the progress indication so that it doesn't
report all of those 0/1 messages. And I added a progress indicator so
that the expensive inventory join shows more than just 0/1 for a long time.
(Also, by doing the pb.update after the optimized path, we don't get
many progress dots on non tty).

The branch is available here:
http://bzr.arbash-meinel.com/branches/bzr/fix-weave-join

There are only 2 patches, the first one fixes the optimized code path
and adds the tests. The second updates the progress bars.

Can I get a review?

John
=:->
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix-weave-join.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060125/11ecbbe3/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060125/11ecbbe3/attachment.pgp 


More information about the bazaar mailing list