[bug] 0.7 Makefile fixes (clean target error suppression)

John Arbash Meinel john at arbash-meinel.com
Mon Jan 23 22:38:47 GMT 2006


Jari Aalto wrote:
> The discussion we had didnät carry into 0.7 :-) Correct these
> to next release:
> 
>     ./setup.py clean
>     running clean
>     find . -name "*.pyc" | xargs rm
>     rm: missing operand
>     Try `rm --help' for more information.
>     make: [clean] Error 123 (ignored)
>     find . -name "*.pyo" | xargs rm
>     rm: missing operand
>     Try `rm --help' for more information.
>     make: [clean] Error 123 (ignored)
>     rm -rf test????.tmp
>     make: *** No rule to make target `distclean'.  Stop.
> 
> The consensus was to add -f option:
> 
>     rm -f
> 
> Jari

Thanks for the reminder.

Check my jam-pending branch at
	http://bzr.arbash-meinel.com/branches/bzr/jam-pending
revno 1508.

I'm wondering if we shouldn't do even more. And clean up stuff like
'bzr-tree-change'.

Also, why do we have:
tag_files=./bzr ./bzrlib/*py ./bzrlib/selftest/*.py

Shouldnet this be:
tag_files=./bzr ./bzrlib/*.py ./bzrlib/*/*.py ./bzrlib/*/*/*.py

Since all the transport stuff is in a directory. 'selftest' doesn't
exist anymore. And we have at least 'bzrlib/tests/blackbox/*.py'

I don't use emacs or 'ctags-exuberant', so I don't really want to make
those changes, but it would seem that the Makefile could use a little
bit of maintenance.

And probably we could alias 'distclean: clean', and add some more .PHONY
targets so that 'check', 'clean', etc are properly handled.

John
=:->


=== modified file 'Makefile'
--- Makefile
+++ Makefile
@@ -10,8 +10,7 @@

 clean:
        ./setup.py clean
-       -find . -name "*.pyc" | xargs rm
-       -find . -name "*.pyo" | xargs rm
+       -find . -name "*.pyc" -o -name "*.pyo" | xargs rm -f
        rm -rf test????.tmp

 .PHONY: all


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060123/3ad7a0f5/attachment.pgp 


More information about the bazaar mailing list