[rfc] [patch] sftp unit tests without ssh

[John Arbash Meinel]

Robey Pointer wrote:
> I think I figured out how to hook up a single "full" sftp test (using 
> ssh), so my bzr.dev.sftp branch now includes that extra test, plus a 
> warn -> warning typo fix.  To avoid spamming the list with huge 
> patches, I'm attaching only a patch against the previous patch.
> 
> robey
> 

The patch looks good.

The only conflict against your branch is the 'if getattr()' line.
Because I used:
if getattr(attr, 'st_mode', None):
  foo

and you used:
if getattr(attr, 'st_mode', None) is not None:
  foo

The problem with yours is that even though paramiko only uses 0 for a
short time, *I* still have that version, and I assume other people might
too. So we want to check for both None and 0, which both conveniently
evaluate to False.

I went ahead and test merged your bzr.dev.sftp branch into
jam-integration. I'm not sure what happened, but the first time I ran
it, it just hung after all the tests had run. I'm guessing a server
thread wasn't being shut down properly.
The second time I ran it, I didn't have any problems.

However, the 'bzr selftest' times both with and without the merge are
still 250s on my machine. So the loopback doesn't seem to be helping.
I'm wondering if it is just not getting enabled somehow. I don't have
time to look at it now.

So summary: Visually the patches look good. I had a weird,
unreproducable hang, and the loopback doesn't seem to be used (or at
least it doesn't speed things up in my testing).

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060123/c833e963/attachment.pgp