[rfc] [patch] sftp unit tests without ssh

[John A Meinel]

Robey Pointer wrote:
> 
> On 22 Jan 2006, at 20:09, John A Meinel wrote:
> 
>> Robey Pointer wrote:
>>> Here's a patch to add a subclass of SFTPServer (called
>>> SFTPServerWithoutSSH) that sets up a fake sftp server over loopback but
>>> uses a special ssh vendor ("loopback") which just wraps a plain socket
>>> instead of setting up both ends of an SSH Transport.  What this means is
>>> that tests using SFTPServerWithoutSSH will use sftp without all the
>>> overhead of actually setting up a secure channel.
> 
> [...]
...

> 
>>> +    def recv_ready(self):
>>> +        return True
>>> +
>>> +
>>
>> Don't we need recv_ready()? I don't know if the code actually tests
>> this, but I know it was a problem for SFTPSubprocess.
>> I thought paramiko expected it to be available if pipelining was enabled.
> 
> Yeah, it does.  I'm guessing you just didn't notice it when you first
> replied, but it's there. :)
> 

I was looking for it next to recv(). Yes, I just missed it. Does PEP8
state how member functions are supposed to be layed out?

You've covered my concerns. +1 from me.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060122/3ddcf86d/attachment.pgp