[BUG][PATCH] fileid_involved fails to unescape xml characters

Martin Pool mbp at sourcefrog.net
Fri Jan 20 04:56:14 GMT 2006


On 19 Jan 2006, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Wouldn't it work to just change the order to:
> 
>             revs = self._revids_to_fetch(last_revision )
>             # nothing to do
>             if revs:
>                 self._fetch_weave_texts( revs )
>                 self._fetch_inventory_weave( revs )
>                 self._fetch_revision_texts( revs )
>                 self.count_copied += len(revs)
> 
> It seems like that would not violate the invariant.

Yes that will do it. 

And it seems like you could still use the same approach for the
optimization.

I'm still going to leave the weave-peeking optimization out of 0.7 and
put it in with these fixes to bzr.dev.

> I'm also wondering how we missed that.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060120/62dbfb59/attachment.pgp 


More information about the bazaar mailing list