storage branch - remaining issues?

[Robert Collins]

On Thu, 2006-01-19 at 16:12 -0600, John Arbash Meinel wrote:
> Robert Collins wrote:
> > On Thu, 2006-01-19 at 10:53 -0600, John A Meinel wrote:
> > 
> > 
> >>Other than having the logic about how to decode a string (whether it is
> >>a url, or a path) in another place, which then needs to be used
> >>everywhere we might get a path.
> >>
> >>For example, I don't think '.' is a valid url. Which means if we want
> >>urls everywhere, then 'Branch.open_containing()' shouldn't be passed '.'.
> > 
> > 
> > As Denys says, '.' is valid, as is '..' and 'foo%14'. u'foo\x14' is not
> > a valid URL though.
> > 
> > They are valid because we have an absolute URL we can interpret them
> > with respect to - the os's current working directory converted to a URL.
> > 
> > Rob
> 
> I thought '..' was not allowed in urls.

It gets normalised when combined with the 'current url' - which must be
a full URL, and results in a full URL.

> I don't really care. I feel like the Transport layer is a nice
> centralized location where paths go through. Which means they can
> interpret the path, and everyone else can consider it a voodoo string.
> 
> I would like to have the conversion earlier, but there are a lot of
> entry points (every command would convert it's own args as appropriate,
> etc).
> 
> We could make Branch.open* be the conversion point, but if we are that
> deep, it is only 1 more step to get to Transport, since the first thing
> open() does is get_transport()

I need to think a bit more on this, which I'll do once the stack of
things-to-do shrinks a bit ;)

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060120/bc0fd0d2/attachment.pgp