[merge] Make merge internals private

Robert Collins robertc at robertcollins.net
Fri Jan 20 00:24:46 GMT 2006


On Wed, 2006-01-18 at 09:24 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Martin Pool wrote:
> > In the version I have
> > <aaron.bentley at utoronto.ca-20060118015458-ba73c07352e1af17>
> > only MergeConflictHandler is in _merge.py.  
> 
> Oh, heh.  I started by moving *everything* to _merge.py, and then moving
> back the things that I thought should be public.
> 
> > Perhaps if this is meant to
> > be a bzrlib-internal class it would be better called
> > _MergeConflictHandler.  (In which case it could go back in merge.py if
> > you wanted :-)
> 
> Oh, I thought we could make entire files private by prefixing them with
> an underscore.  _merge._MergeConflictHandler seems like overkill, but I
> can put it back in merge, instead.

We can. bzrlib._module means the entire module is private. Likewise
bzrlib._package makes the entire package private.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060120/44e99ac5/attachment.pgp 


More information about the bazaar mailing list