[PATCH 0/4] Speed improvement in fetch/clone

[John Arbash Meinel]

Goffredo Baroncelli wrote:
> On Wednesday 18 January 2006 05:00, Martin Pool wrote:
> 
>>On 15 Dec 2005, Goffredo Baroncelli <kreijack at alice.it> wrote:
>>
>>>Hi all,
> 
> 
>>I'm just about to commit the merge of this into bzr.dev.  Robert has
>>suggested that it should be in 0.7 too because of the relative
>>simplicity of the change and the likelihood of a large performance gain,
>>and I agree.
>>
>>I'm just doing a branch of the main branch using this as a final manual
>>check.  
> 
> 
> Thanks for your great job !!!!!!!!!!
> 
> With our changes and the little patch below ( which implements multiple request in one 
> connection) I was able to copy the bzr.dev repository from a local server in less 
> than 2.5 minutes !!!!!
> 
> $ time ../bzr.dev/bzr clone 'http://127.0.0.1:8077/bazaar/bazaar-ng_stable_branch'
> nched 1522 revision(s).
> 
> real    2m25.821s
> user    0m50.689s
> sys     0m12.499s
> 
> 
> 
> 
>>It does seem to have affected the progress bar display. (?) 
> 
> Yes, i will check why
> 
> 
>>-- 
>>Martin
> 
> Goffredo
> 

I'm a little concerned that your http_get class doesn't handle HTTPS,
and it doesn't handle all of the possible return codes correctly (nor
the fact that HTTP/1.0 would want to disconnect unless it was passed
keep-alive or somesuch).

I think you could refactor it into a plugin, which just overrides
transport.http.get_url into a different function. Then people could
install it if they wanted the performance improvement, but it wouldn't
have to officially support everything that we would want the core of bzr
to support.

I'm also curious how it compares with Martin's pycurl work.

But it is definitely nice to see performance improve with http branches.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060118/490dda87/attachment.pgp