storage branch - remaining issues?

[Robert Collins]

the following things in the diff look like things we should address
before merging:

+        elif mode == 'r':
+            # XXX: Do we really want errors='replace'?   Perhaps it
should be
+            # an error, or at least reported, if there's
incorrectly-encoded
+            # data inside a file.
+            # <https://launchpad.net/products/bzr/+bug/3823>
+            return
codecs.getreader('utf-8')(self._transport.get(relpath),
errors='replace')

There were a couple of warts left, that I have fixed up: the repository
was not taking out any read or write locks on most of its methods, and
LockableFiles did not take a write lock out for put[_utf8].

Other than that, I think this is good to go. I'm pushing my tweaks now.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060118/69372b24/attachment.pgp