[rfc] [patch] speeding up bzr log with a tree delta iterator

[Martin Pool]

On 17 Jan 2006, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Denys Duchier wrote:
> > After an IRC conversation with lifeless, I implemented a tree delta iterator
> > with which similar speed improvements for bzr log can be obtained as with my
> > inventory caching patch.
> > 
> > This patch is available as revno=1521 of my bzr.fix.log branch at:
> > 
> >              http://delta.univ-orleans.fr/~duchier/bzr/bzr.fix.log
> > 
> 
> This seems useful.
> 
> I'm curious why we stopped using 'deltas_for_log_forward' and
> 'deltas_for_log_reverse.' Those did exactly what you are doing with your
> iterator (kept track of the previous entry, and computed the appropriate
> delta).

I disabled them while cleaning up the log code a while ago, because (as
I recall) the code was getting too tied up together.  I'm in favour of
putting them back in and this looks like a reasonably good patch, though
we should make sure there are a test checking forward and backward
verbose logs.

> I would probably also prefer it if we weren't iterating by revno. But
> rather by revision_id.
> Though I guess you can't really iterate forward without a
> revision-history. (Though you could iterate backwards to create the
> history, and then iterate forwards across it).

Right, perhaps they should call a common function which is given a list
of revision ids to walk.

> Maybe we should yield 'lo_tree_rev_id, hi_tree_rev_id' or something like
> that as well. That way you don't have to iterate over the revision
> history separately and make sure you stay in sync.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060118/d13563fc/attachment.pgp