[rfc] [patch] speeding up bzr log with a tree delta iterator

[Denys Duchier]

John Arbash Meinel <john at arbash-meinel.com> writes:

> I'm curious why we stopped using 'deltas_for_log_forward' and
> 'deltas_for_log_reverse.' Those did exactly what you are doing with your
> iterator (kept track of the previous entry, and computed the appropriate
> delta).

I didn't know they existed. they seem to _want_ to do something similar, but
they look wrong - what is this:

                  this_tree = EmptyTree(branch.get_root_id())

business?  I don't understand this code... but mine seems clear (to me, that is,
of course).

Also, I tried to provide a minimally invasive patch that closely followed and
respected the semantics of the code that was actually used.

I am fine with changing it, but you guys have to decide what you want.

Keep in mind that my patch does the same as before only much more efficiently.
The abstraction can always be revised later, but we can have the performance
improvement today :-)

Cheers,

--Denys