[rfc] [patch] revisionspec fix for branch:../../branch2

Denys Duchier duchier at ps.uni-sb.de
Tue Jan 17 22:20:57 GMT 2006


John Arbash Meinel <john at arbash-meinel.com> writes:

> -                      bzrlib.store,
> +                      bzrlib.store

sorry, I assumed I put that comma there, that's why I took out.

> Also, in your bzr.patches branch, you have some stuff like the
> test_hashcache changes where you have a
> try:
>   func('a')
> except FixThisError:
>   pass

yes, I explained this.  FixThisError is defined but not raised.  It is just a
place marker to indicate that we know that something will need fixing on
e.g. Windows, but, on lifeless's advice, I am not catching anything and leaving
it up to whomever actually experiences the exception to fix it.

> Did we +2 'FixThisError'?

I think so, but this informal approval business is sometimes leaves me unsure.
Maybe lifeless should confirm (or infirm as the case maybe).

--Denys






More information about the bazaar mailing list