Serializer_v5._pack_revision and _unpack_revision to become public?

[Robert Collins]

On Tue, 2006-01-17 at 01:06 +0100, David Allouche wrote:
> On Mon, 2006-01-16 at 09:56 +1100, Robert Collins wrote:
> > We're deprecating all the XML facilities anyway. So : what does your
> > extension data look like? Would a black-box storage mechanism that lets
> > you do much the same thing suffice? 
> 
> The bzrk cache I am using is a XML file store in .bzr/x-bzrk-revisions.
> 
> It is read using Branch.controlfile and written using the same
> combination of Branch.controfilename and AtomicFile as .bzr/parent.
> 
> Its format looks like:
> 
> <collection>
>   <revision yadda yadda>blah blah blah</revision>
>   <dummy revision_id="jabberwock"/>
>   ...
> </collection>
> 
> <revision> and <dummy> items are unordered.

so whats the extension data ? the dummy entries ?

> The whole file is read and written using elementtree classes imported
> from bzrlib.xml (to reuse the import logic that uses cElementTree if
> it's available).
> 
> The <revision> elements are created and processed using _pack_revision
> and _unpack_revision.
> 
> The <dummy> elements are used to record which revisions were previously
> found to be ghosts (there is a "bzr vis --ghost" option to ignore
> <dummy> elements when reading the cache).
> 
> The requirements for the cache are the following:
> 
>       * Fast to read and write. cElementTree is fast at reading, but
>         still seems to use a Python implementation for writing. I would
>         like no slower reading and faster writing.
>       * Safe to use with data that is no more trusted than any branch
>         data than you can find anywhere on the internet.
>       * Allows embedding of blackbox bzr data in a foreign data format.
>         I do not care how revisions are stored, but I want to mix them
>         with my own data.

ah, so the thing here is not storing extension data in bzr storage, its
serialising bzr object in your own storage format.

I'm inclined to say 'bzr serialisation is library internals, if you are
storing bzr objects, just use pickle or $any python serialisation form'.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060117/d2ab7fc8/attachment.pgp