sftp tests are slow

[John Arbash Meinel]

Robert Collins wrote:
> On Thu, 2006-01-12 at 19:48 +1100, Martin Pool wrote:
> 
>>On 10 Jan 2006, Robey Pointer <robey at lag.net> wrote:
>>
>>>>>Yes, this is slow. We chatted on IRC about this - its about 10 times
>>>>>slower than starting openssh... I find it hard to believe that  
>>>>>this is
>>>>>intrinsic to python - I have to regard it as a bug in the stub  
>>>>>server.
>>>
>>>10 times is hard to believe -- what did you use to test that?
>>
>>As I understand it, SFTP is fairly well layered above SSH: you can run
>>it equally well over a plain tcp socket. 
>>
>>Why can't we run the SFTP tests over an in-process representation of a
>>plain socket?  Doing negotiation, encryption, etc is not going to prove
>>anything much useful about whether we're using SFTP in the right way.
> 
> 
> Yup, I agree with this.
> 

Same here. I guess the person to ask is Robey... How hard is it to
change the underlying paramiko.Transport() connection to just being a
connection to a socket?

It seems like we could hook into the '_get_ssh_vendor()', and have one
vendor be 'tcp_socket', or something like that.
Then the test suite could override the default ssh vendor, and spawn the
TCPSocketSFTPServer.

> 
>>I guess some areas, such as authentication, do need to be tested on real
>>ssh but the majority probably does not.
> 
> 
> In fact, this is more an ssh specific test than a general sftp test -
> though we dont have any transport authentication tests AFAIK and it
> would be good to have them.
> 
> Rob
> 

I think we should test that we can connect to an ssh server. But that
would be a single test, not all of them.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060115/07e6df4c/attachment.pgp