[PATCH][MERGE] Improvements to is_ignored, take 2

[Jan Hudec]

On Sat, Jan 14, 2006 at 14:17:42 -0600, John A Meinel wrote:
> I realize that inside a shell, *foo doesn't match '.foo', are you
> specifically requesting that behavior from the bzr ignore pattern? It
> doesn't really seem useful to me.
> In general, you want hidden (. prefixed) files to be ignored. So by
> ignoring them with the ignore pattern, you are actually making them more
> obvious, not less (double negative => positive sort of thing)

I am not sure it is undesired. Files normally should not be hidden. So
I think it's actually right that you would ignore hidden files separately.

> As far as being bound to a transaction...
> How far do we want transaction to extend into everything? Right now, it
> is a little bit ugly to pass it around everywhere (partially because
> 'transaction' is such a long word).

(but 'txn' is not ;-))

> 'session' might be a lot more palatable, and closer to what we actually
> mean by the class. (We can't rollback a Transaction, so it isn't really
> a transaction as such).

Yes, the name sounds better fit for what the object actually means.

> Also, right now, we only really use the PassThroughTransaction, which
> doesn't do anything, and bzr only runs long enough to do everything 1
> time anyway. A future GUI/server would probably care more that things
> are cleaned up after every operation, since bzrlib would stay resident
> in ram for longer. So I'm not saying we don't want to use it, I'm just
> trying to figure out if it is worth doing that right now.

I actually already have part of such GUI ;-). It has mercurial backend so
far, but after I get to finish the commit dialog, I am quite likely to start
writing bzr backend.

Anyway, the question is how the two objects, Session and
Branch/WorkingTree/whatever should be related. Should we call methods on the
object and give all the methods a Session? That would be a hell lot of
passing it around. Or keeping it somewhere global or in the instance? But
what about threads? Every thread should have it's own Session, but they
certainly don't want their own Branch and WorkingTree objects...

-- 
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060114/14187c22/attachment.pgp