[patch] storage refactoring ready to merge?

John Arbash Meinel john at arbash-meinel.com
Thu Jan 12 15:55:01 GMT 2006


Aaron Bentley wrote:
> John Arbash Meinel wrote:
> 
>>>My biggest
>>>concern is that Repository, WorkingTree, and Branch are all going to
>>>lock the same file. Which is valid under Linux, but not Windows. I
>>>describe it more later.
> 
> 
> No, Repository locks README.  Perhaps not optimal, but I can't imagine
> how it would produce a correctness problem.  I suppose a
> ProxyLocableFiles that used the Branch's LockableFiles would be another
> option.
> 
> +    def __init__(self, transport, branch_format):
> +        object.__init__(self)
> +        self.control_files =
> LockableFiles(transport.clone(bzrlib.BZRDIR), 'README')
> +
> 
> Aaron

And WorkingTree.lock() still just thunks into self.branch.lock()?

I agree that 'README' is less than ideal, but at least it is different.
And README should always exist.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060112/92d3414d/attachment.pgp 


More information about the bazaar mailing list