[patch][merge] sftp/http tweaks

Robey Pointer robey at lag.net
Thu Jan 12 07:25:12 GMT 2006


On 11 Jan 2006, at 18:47, Robey Pointer wrote:

>
> On 11 Jan 2006, at 17:14, Robert Collins wrote:
>
>> On Wed, 2006-01-11 at 07:08 -0600, John Arbash Meinel wrote:
>>
>> ...
>>> So, I'm +1 on your changes. We just need to get another.
>>
>> +1 with a tweak:
>>
>> +# don't use prefetch unless paramiko version >= 1.5.2 (there were  
>> bugs
>> earlier)
>> +_default_do_prefetch = False
>> +_paramiko_version = getattr(paramiko, '__version_info__', None)
>> +if (_paramiko_version is not None) and (_paramiko_version >= (1, 5,
>> 2)):
>> +    _default_do_prefetch = True
>>
>> to:
>>
>> +# don't use prefetch unless paramiko version >= 1.5.2 (there were  
>> bugs
>> earlier)
>> +_default_do_prefetch = False
>> +if (getattr(paramiko, '__version_info__', (0, 0, 0) >= (1, 5, 2)):
>> +    _default_do_prefetch = True
>>
>>
>> I think thats a whole lot easier to read.
>
> Agreed, and +1 to that modification, if it matters.

I pushed this patch into bzr.robey.
<http://www.lag.net/~robey/bzr.robey/>

robey





More information about the bazaar mailing list