[rfc][patch] test-providers branch ready for merge

[Martin Pool]

On 12 Jan 2006, Robert Collins <robertc at robertcollins.net> wrote:
> Ok - all done.
> 
> Attached is the alterations to the patch if you want to eyeball it.

Looks wonderful.   Thanks very much.

This +2 review thing seems to be going well!

> Or pull the branch ;)

I'll pull & push shortly.

>  class TestTransportProviderAdapter(TestCase):
> +    """A group of tests that test the transport implementation adaption core.
> +
> +    This will be generalised in the future which is why it is in this 
> +    test file even though it is specific to transport tests at the moment.
> +    """
>  
>      def test_get_transport_permutations(self):
> +        # this checks that we the module get_test_permutations call
> +        # is made by the adapter get_transport_test_permitations method.
>          class MockModule(object):
>              def get_test_permutations(self):
>                  return sample_permutation
> @@ -88,6 +95,11 @@
>                           adapter.get_transport_test_permutations(MockModule()))
>  
>      def test_adapter_checks_all_modules(self):
> +        # this checks that the adapter returns as many permurtations as
> +        # there are in all the registered# transport modules for there
> +        # - we assume if this matches its probably doing the right thing
> +        # especially in combination with the tests for setting the right
> +        # classes below.
>          from bzrlib.transport import (TransportTestProviderAdapter,
>                                        _get_transport_modules

I'm just curious why these are all comments not docstrings?  (No need to
reiterate the patch.)

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060112/9bd8cba4/attachment.pgp