patch: more sftp unit tests

[Wouter van Heyst]

On Tue, Jan 10, 2006 at 09:57:44AM -0800, Robey Pointer wrote:
> 
> On 10 Jan 2006, at 6:55, Wouter van Heyst wrote:
> 
> ><snip>
> >
> >No pprinting when dumping? I can live with that, but perhaps both  
> >would
> >be nice.
> 
> The pprint output is huge, so IMHO you really want one or the other,  
> but not both.

Fair enough.

<snip>

> The previous version had a bug, which I forgot to mention last time:  
> By removing the item as it was being iterated, the loop actually  
> ended up skipping the next option.  (Meaning for instance, "--profile  
> --no-plugins" didn't work.)

Yeah, that has bitten me as well in the past.

> I'm not overly fond of the "i" index loop, but I wanted to read the  
> filename arg, and you can't really do that from within "for a in".   
> Feel free to change that loop entirely; it made me make unhappy faces  
> when I was writing the patch.  I'm not sure why we don't just use  
> optparse.

Hmm, I didn't think of that.

optparse sounds like a good idea. It does remind me of how slow bzr
startup is due to excessive importing (compare to mercurial, which feels
blazingly fast), should be able to get away with one more module though.

Wouter van Heyst