Solution for baz2bzr revision ids on windows

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> I would have preferred to have bzr handle some of this internally. But
> depending on how we do it, bzr might end up doing the same thing, so we
> can just stop translating in baz2bzr if we know that bzr is going to
> translate itself.

Because these ids will be stored in revision and inventory files
directly, I believe that would require another namespace upgrade.

> So if I'm understanding you correctly, you are willing to create
> 'Arch-2' which is a namespace which passes
> urllib.quote(x.encode('utf-8')) as the revision-id.

Right.

> We have to use a slightly custom quoter, since urllib.quote doesn't
> default to escaping '/' => '%2F'.

No, see other mail.

>>This would permit using any character as the namespace separator, but
>>for the sake of aesthetics, I think we should use a different character.
>> Semicolon and comma are my leading candidates.
> 
> 
> I'm up for either one.
> But honestly, we can stick with :, it just becomes:
> 
> Arch-2%3Ajohn%40arbash-meinel.com--2005%2Fmifar--dev--0.6
> 
> This isn't the most aesthetically pleasing entry. But it means it would
> be compatible with what bzr might do in the future.

Yeah, I guess the aesthetics are pretty much gone anyway.

> def quote(arch_id):
>   return urllib.quote(arch_id).replace('/', '%2F')
> 
> quote(u'Arch-2:erik at Bågfors.com/test--proj--0.6'.encode('utf-8'))
> 'Arch-2%3Aerik%40B%C3%A5gfors.com%2Ftest--proj--0.6'
> 
> I didn't think arch-ids could contain non ASCII characters. I thought
> that was in the plan, but arch never got that far.

Dunno.  Maybe it's second system effect, but I'd rather be paranoid.

> If I have to, I can make the time to do this. I need it.

I think that would be best.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDxSuG0F+nu1YWqI0RApaDAKCGNAryyqdojnsgZwNpeMVcl/JVngCfV0tI
Zff7e/HfIPwVyQha0iMd5zU=
=RrKD
-----END PGP SIGNATURE-----