[PATCH][MERGE] Improvements to is_ignored

[John A Meinel]

Martin Pool wrote:
> On 10 Jan 2006, John A Meinel <john at arbash-meinel.com> wrote:
>> Jan Hudec wrote:
> 
>> Here are my results:
>> time bzr status
>> real    0m8.374s
>> user    0m7.840s
>> sys     0m0.404s
>>
>> time bzr.ignore/bzr status
>> real    0m5.497s
>> user    0m4.988s
>> sys     0m0.412s
> 
> Very nice.
> 
>> So it was able to shave a lot of the time off. This is with 71 ignore
>> patterns, and 805 ignored files.
>>
>> I also found an interesting problem if you don't use (?:), specifically:
>> bzr: ERROR: exceptions.AssertionError: sorry, but this version only
>> supports 100 named groups
>>   at /usr/lib/python2.4/sre_compile.py line 506
>>   in compile
> 
> So we should add a test with enough patterns to provoke this, calling
> both bzr status and bzr ignored.
> 

I agree.

Also, I found a small advantage to using the pattern (a$)|(b$)|(c$)
versus doing ((a)|(b)|(c))$.
Which is nice, because it is easier to do.
John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060110/11f96307/attachment.pgp