patch: more sftp unit tests

[Robey Pointer]

On 10 Jan 2006, at 6:55, Wouter van Heyst wrote:

> <snip>
>
> No pprinting when dumping? I can live with that, but perhaps both  
> would
> be nice.

The pprint output is huge, so IMHO you really want one or the other,  
but not both.

>
>> -    for a in argv:
>> +    argv_copy = []
>> +    i = 0
>> +    while i < len(argv):
>> +        a = argv[i]
>>          if a == '--profile':
>>              opt_profile = True
>>          elif a == '--lsprof':
>>              opt_lsprof = True
>> +        elif a == '--lsprof-file':
>> +            opt_lsprof_file = argv[i + 1]
>> +            i += 1
>>          elif a == '--no-plugins':
>>              opt_no_plugins = True
>>          elif a == '--builtin':
>> @@ -501,9 +514,10 @@
>>          elif a in ('--quiet', '-q'):
>>              be_quiet()
>>          else:
>> -            continue
>> -        argv.remove(a)
>> -
>> +            argv_copy.append(a)
>> +        i += 1
>> +
>> +    argv = argv_copy
>
> Why not just use something like:
>
>   for a in in list(argv):
>     argv.remove(a)

The previous version had a bug, which I forgot to mention last time:  
By removing the item as it was being iterated, the loop actually  
ended up skipping the next option.  (Meaning for instance, "--profile  
--no-plugins" didn't work.)

I'm not overly fond of the "i" index loop, but I wanted to read the  
filename arg, and you can't really do that from within "for a in".   
Feel free to change that loop entirely; it made me make unhappy faces  
when I was writing the patch.  I'm not sure why we don't just use  
optparse.

robey