remove --all from bzr uncommit

[John Arbash Meinel]

Wouter van Heyst wrote:
> On Tue, Jan 10, 2006 at 08:44:00AM -0600, John Arbash Meinel wrote:
> 
>>Aaron Bentley wrote:
>>
>>>John Arbash Meinel wrote:
>>>
>>>
>>>
>>>>>See my 'clean-weave' plugin. Otherwise, there is nothing inside core
>>>>>bzr. (But uncommit started life as a plugin too :)
>>>
>>>
>>>Speaking of uncommit, it is verrry slowwwww when uncommitting a hundred
>>>revisions, or so.  (Something I did recently, to find that .bzrignore
>>>behaviour change.)
>>>
>>>Aaron
>>
>>Couldn't you have just annotated the code at that point? Or cracked open
>>the weave in an editor?
>>
>>Actually, the issue is in the loop I was using to handle the '--all'
>>behavior. It was extracting all of the inventories so it would know what
>>texts needed to be removed.
>>Since we're no longer doing that, I need to clean up the loop a little
>>bit more. (I got rid of the actual attempt to remove the files, I just
>>left in the code that prepared to remove them).
>>
>>Attached is a patch which cleans up the dead lines. If someone gives it
>>a +1, I'll put it in my integration branch.
> 
> 
> It is already in, but if it wasnt:
> 
>   bzr uncommit -r 1000  904.95s user 27.80s system 64% cpu 24:07.66 total
> 
> after the change:
> 
>   bzr uncommit -r 1000  8.89s user 0.86s system 75% cpu 12.972 total
> 
> So thanks for putting it in :)
> 
> Wouter van Heyst
> 
> 

Yeah, reading 500 or so inventories is very expensive. Thanks for
showing how much.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060110/0ed7b3c3/attachment.pgp