remove --all from bzr uncommit

[John Arbash Meinel]

Aaron Bentley wrote:
> John Arbash Meinel wrote:
> 
> 
>>>See my 'clean-weave' plugin. Otherwise, there is nothing inside core
>>>bzr. (But uncommit started life as a plugin too :)
> 
> 
> Speaking of uncommit, it is verrry slowwwww when uncommitting a hundred
> revisions, or so.  (Something I did recently, to find that .bzrignore
> behaviour change.)
> 
> Aaron

Couldn't you have just annotated the code at that point? Or cracked open
the weave in an editor?

Actually, the issue is in the loop I was using to handle the '--all'
behavior. It was extracting all of the inventories so it would know what
texts needed to be removed.
Since we're no longer doing that, I need to clean up the loop a little
bit more. (I got rid of the actual attempt to remove the files, I just
left in the code that prepared to remove them).

Attached is a patch which cleans up the dead lines. If someone gives it
a +1, I'll put it in my integration branch.

John
=:->

=== modified file 'bzrlib/uncommit.py'
--- bzrlib/uncommit.py
+++ bzrlib/uncommit.py
@@ -31,11 +31,6 @@
         rev_id = rh.pop()
         if verbose:
             print 'Removing revno %d: %s' % (len(rh)+1, rev_id)
-        rev = branch.get_revision(rev_id)
-        inv = branch.get_revision_inventory(rev_id)
-        inv_prev = []
-        for p in rev.parent_ids:
-            inv_prev.append(branch.get_revision_inventory(p))

     new_rev_history.write('\n'.join(rh))
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060110/dd5eb4ae/attachment.pgp