default ignores don't ignore '.swp'

[John Arbash Meinel]

Aaron Bentley wrote:
> John Arbash Meinel wrote:
> 
>>>Aaron Bentley wrote:
>>>Really. Having .bzrignore doesn't override the defaults as far as I can
>>>tell. It just adds to them.
> 
> 
> It used to.  Here's the code from revision 101:
> 
>     def get_ignore_list(self):
>         """Return list of ignore patterns."""
>         if self.has_filename(bzrlib.IGNORE_FILENAME):
>             f = self.get_file_byname(bzrlib.IGNORE_FILENAME)
>             return [line.rstrip("\n\r") for line in f.readlines()]
>         else:
>             return bzrlib.DEFAULT_IGNORE
> 
> 1. the defaults are used if there's no .bzrignore
> 2. the first time the 'bzr ignore' command is used, the defaults are
> copied into .bzrignore (as well as your input)
> 3. from then on, it only uses .bzrignore to determine the patterns to
> ignore.
> 
> 
>>>Basically, .bzrignore is things you want to ignore *on top of* what bzr
>>>defaults to ignoring.
> 
> 
> I believe that change was a bad idea.  It appears to have been made in
> revision 102, but I still think it's wrong.
> 

Wow, all the way back into almost 2-digit revision numbers. Now I think
each of the main developers generate about 100 revisions a week. :)

> 
>>>Which is why Makefile.in should not be in the default ignores. You can
>>>easily type 'bzr ignore Makefile.in' if they are autogenerated, but you
>>>can't get rid of a default ignore.
> 
> 
> I believe there needs to be a way to override the default ignores.  But
> if you currently cannot, then I agree that Makefile.in should not be in
> them.  I'd add that .pyc should also not be in them, since it may be
> source for some projects.
> 
> Aaron

I agree that it might be nice to be able to override the default
ignores. I'm a little against dumping all ignore patterns into
.bzrignore, because there are quite a few, and it makes the file a
little ugly.
Also, a bzr upgrade can do something like make .DS_Store ignored
everywhere, rather than having to manually do it in every project that
now has a non-default ignore set.

If you know of any real-world projects that use .pyc files as source,
then we certainly can consider removing them from the default ignore
list. But for the same reason we default to ignoring *.o, (and possibly
*.obj) is that the chance of them being source is very low.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060109/86b0f8f5/attachment.pgp