[RFC] more encodings tests [was: bzr handles unicode]

[John Arbash Meinel]

Alexander Belchenko wrote:
> John Arbash Meinel пишет:
> 
>> I have a branch available here:
>> http://bzr.arbash-meinel.com/branches/bzr/encoding/
> 
> 
> John, I'm currently work with your branch. Here some patches for r1527:
> 
> test_non_ascii.diff -- little fix for work in process
> msgeditor.py -- added errno code for win32 permission denied error
> 
> And most important:
> 
> test_log.diff -- I've add my test for checking different encodings of
> log command output. It was surprising to me but this test was fail. But
> when I run manually python bzr log from command line I see that bzr
> works correct. I don't understand what wrong with my test. Probably
> there is some side effect of wrapping wrapped dummy sys.stdout stream?
> 
> Or may be my test is unnecessary because your tests already cover my case?
> 
> And there is one more bug in test_non_ascii.py : test_log test. This
> test skipped on my win32 box 'cause cp1251 cannot represent name of Erik
>  Bågfors. But when selftest do final cleanup of temp directory of this
> test there is permission denied error raised. It means that some files
> in this dir is not closed. (Yeah, I know, bad windows cannot unlink file
> currently in use). I don't dig into this problem yet.
> 
> -- 
> Alexander
> 

Thanks for the patches. I was really hoping that these would run on your
system, since you have a semi-unique configuration. I would have thought
that all non_ascii tests would be skipped if I can't encode Erik's name.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060107/ff1574f6/attachment.pgp