error in the tests
John Arbash Meinel
john at arbash-meinel.com
Thu Jan 5 17:28:54 GMT 2006
Erik Bågfors wrote:
> 2006/1/4, Robert Collins <robertc at robertcollins.net>:
>
>>On Tue, 2006-01-03 at 18:00 +0100, Erik Bågfors wrote:
>>
>>>Hi
>>>
>>>As I've said I'm having problems running the tests. I've figured out why.
>>>
>>>While running tests $BZREMAIL and $EMAIL are both ignored and the
>>>comitter comes from the user info. Well, my full name is "Erik
>>>Bågfors" and the å messes up the tests.
>>>
>>>If I change my name in /etc/passwd the tests passes.
>>
>>I think that reflects a bug in bzr rather than a bug in the tests - we
>>should support "Erik Bågfors" as your name.
>
>
>
> Well, there is no problem with that name is I just run bzr. It's when
> I run the test it fails.
>
> more info
>
> : [bagfors at zyrgelkwyt]$ ; echo $EMAIL
> Erik Bågfors <erik at bagfors.nu>
>
> : [bagfors at zyrgelkwyt]$ ; echo $EMAIL | xxd
> 0000000: 4572 696b 2042 c3a5 6766 6f72 7320 3c65 Erik B..gfors <e
> 0000010: 7269 6b40 6261 6766 6f72 732e 6e75 3e0a rik at bagfors.nu>.
>
> So, it's all utf-8
>
> : [bagfors at zyrgelkwyt]$ ; bzr ci -m foo1
> Committed revision 1.
>
> : [bagfors at zyrgelkwyt]$ ; grep Erik /etc/passwd | xxd
> 0000000: 6261 6766 6f72 733a 783a 3130 3030 3a31 bagfors:x:1000:1
> 0000010: 3030 303a 4572 696b 2042 c3a5 6766 6f72 000:Erik B..gfor
> 0000020: 732c 2c2c 3a2f 686f 6d65 2f62 6167 666f s,,,:/home/bagfo
> 0000030: 7273 3a2f 6269 6e2f 6261 7368 0a rs:/bin/bash.
>
> Also utf-8
>
> : [bagfors at zyrgelkwyt]$ ; unset EMAIL
> : [bagfors at zyrgelkwyt]$ ; echo test >> foo
> : [bagfors at zyrgelkwyt]$ ; bzr ci -m 'foo2'
> Committed revision 2.
>
> : [bagfors at zyrgelkwyt]$ ; bzr log
> ------------------------------------------------------------
> revno: 2
> committer: Erik Bågfors <bagfors at zyrgelkwyt>
> branch nick: p
> timestamp: Wed 2006-01-04 09:04:13 +0100
> message:
> foo2
> ------------------------------------------------------------
> revno: 1
> committer: Erik Bågfors <erik at bagfors.nu>
> branch nick: p
> timestamp: Wed 2006-01-04 09:03:27 +0100
> message:
> foo1
>
> So, no problems there... bzr works with my name, both set in EMAIL and passwd.
>
> Most of the test works, a few fails, the first line it fails on is in
> test_missing.py
> where it runs
>
> # compare a against b
> os.chdir('../a')
> lines = self.capture('missing ../b', retcode=1).splitlines()
> # we're missing the extra revision here
> self.assertEqual(missing, lines[0])
>
> It seams like it dies either on self.capture or on self.assertEqual.
Well, I'm thinking it is a problem with self.capture(). The problem is
just figure out how to replicate the bug, so that we can write a test
case, fix it, and make sure it doesn't come back.
>
> I think you will see the same thing is you change "commit -m more"
> that you have above to "commit -m räksmörgås" or something like that.
>
> Regards,
> The man with the strange name.
Thanks for the bug report at least. :)
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060105/b39bcdc4/attachment.pgp
More information about the bazaar
mailing list