bazaar web interface

[John Arbash Meinel]

Goffredo Baroncelli wrote:
> On Thursday 05 January 2006 00:26, you (Robert Collins) wrote:
> 
>>On Thu, 2006-01-05 at 00:15 +0100, Goffredo Baroncelli wrote:
>>
>>>Hi all,
>>>
>>>I announce a new version of the bazaar web interface plugin. From the last version 
>>>the changes are:
>>
>>Sweet. I have a question (sorry for not just trying, call me lazy :)) -
>>if I have a branch that has only a .bzr dir, none of the actual files
>>checked out - will it still work ? 
> 
> 
> Yes: the code doesn't access to the working dir, so if the files exist or not 
> shouldn't matter.
> 
> For example, after your email I removed the file from the working dir of the 
> repository located at http://goffredo-baroncelli.homelinux.net/bazaar/bzr-fileid-involved :
> but you can browse the log/inventory/content/diff without problem...
> 
> Goffredo
> 

I don't know when you introduced it, but I never realized that browsing
contents gave you the annotated lines. Very nice.

The only problem being bandwith, since each line is prefixed with:
<tr class="parity0"><td class="annotate"><a
title="ghigo at therra.bhome-20051101184844-78e20f6fdc4d9dae"
href="?cmd=revision;rev=ghigo at therra.bhome-20051101184844-78e20f6fdc4d9dae">55</a>:<a
title="ghigo at therra.bhome-20051101184844-78e20f6fdc4d9dae"
href="?cmd=revision;rev=ghigo at therra.bhome-20051101184844-78e20f6fdc4d9dae">&#103;&#104;&#105;&#103;&#111;&#64;&#116;</a></td><td><pre></pre></td></tr>

I wonder if there would be a way to do that more cleanly. Maybe with
javascript which rewrites the document. Or maybe just expect people do
have mod_gzip enabled :)

Actually, I would say the problem is that you are separately doing a
reference for the digit, and then the short revision name. Probably
because you didn't want to annotate the ':'. I think it is worth the
bandwidth savings to just annotate them both with the same <a> block.

I'm also not sure why you are html escaping all of the revision id
characters. 'ghigo at th' is perfectly reasonable in ascii. I'm guessing it
is just because you have a unicode string, which defaults to being
escaped when substituted in the template.

Probably better to give encoding=utf-8, and then encode strings like that.

But in general, *very* nice.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060104/eb59aa61/attachment.pgp