[RFC][PATCH]

[Robert Collins]

Hi, http://people.ubuntu.com/~robertc/baz2.0/test-providers is ready for
a review.

I think its ready for merge with one caveat, which I need some input on:
the new mode tests.


The problem is discriminating between transports that can set modes, and
transports that cant set modes. 

For instance, HTTP can never do modes - the protocol does not 'get' it.
SFTP can - and we could make stub_server talk to a transport instance
with MemoryTransport backing it, to get a sftp server with mode support
on windows.
MemoryTransport can do modes, but does not write to the fs.

So right now Johns new transport tests are inactive, because they are
all in the defunct test_transport TransportTestsMixIn class. 

I can see several routes out:

a) test mode setting as part of the Transport interface: check the modes
are set via stat(), and skip those tests on win32 and for read only
transports.
b) have two implementation tests for transport - one for the primary
interface, and one for mode aware transports 
c) test that the mode is set on the backend correctly on a per transport
basis (basically c, but along the lines of the old transport tests.)

My preference is a), but I wanted input first..

and separately to that, I'd just -love- a +1 for the rest of the branch.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060103/ea95f3b4/attachment.pgp