[rfc][patch]

[John Arbash Meinel]

Erik Bågfors wrote:
> 2005/12/24, Erik Bågfors <zindar at gmail.com>:
> 

...

>>Oh, that was just a mistake.
>>
>>Both fixed. In the same place.
> 
> 
> 
> John, Can you take a look at this again?

In bzrlib/builtins.py and blackbox/test_pull.py you have tab characters
which need to be expanded.

> /Erik
> 

I think it is better to do:
rev_id = revision[0].in_history(br_from).rev_id

_match_on() is a private interface.


If we are being picky, you tests do:
self.assertEquals(a.revno(), 4)

I think we decided the prefered way is
self.assertEquals(4, a.revno())

I agree that the former feels a little bit more natural. But when
reviewing errors, it is easier to read the correct value first. And it
is nice if we standardize, so that when reading test failures, it is
easier to see what is wrong.

This isn't a big deal with simple numbers. It is more when you have a
long array, which is breaking across lines, etc.

The concept is +1, just needs a couple of refinements to be code clean.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060102/7fc8abe5/attachment.pgp