selftest output noisy with debug messages (was Re: [patch] exclude .bzrignore from export, this time with tests)

[John A Meinel]

Jamie Wilkinson wrote:
> This one time, at band camp, John A Meinel wrote:
>> Jamie Wilkinson wrote:
>>> This one time, at band camp, Jamie Wilkinson wrote:
>>>> I've repatched it now, and added blackbox tests.
>>> Incidentally, there's a lot of crap in the output of selftest, is all that
>>> test output necessary?
>>>
>>>
>> I assume you are talking specifically about the
>> "test_set_user_setting_sets_and_saves broken:" and such comments.
> 
> Yeah.
> 
>> They are there to remind people that they should be fixed. Basically it
>> means that a test isn't being run, and should be updated so that it can
>> be run.
>>
>> At this point we might be able to switch to raise TestSkipped(), which
>> would be less of an eyesore, but the eyesore is the reason it is there
>> (to encourage people to fix it :)
> 
> Well, perhaps the authors of those comments should discuss it on list?  I
> suspect that the people who can answer these questions haven't been asked :)
> 
> 

Well, I believe it was done by both Robert Collins and Martin Pool, the
2 primary developers. :)

I agree that it is ugly and we should try to clean those tests up. If
you want to look into it, probably for now we could just change:

print 'something'
return

Into

raise TestSkipped('something')

That at least would get rid of the noise, and change it into ~~~S~~~

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051229/c616ba86/attachment.pgp