[rfc] revision-storage

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
| Some comments...
|
| Why does LockableFiles take both a transport and a base directory, which
| means that it has to call _rel_controlfilename everywhere. I realize
| this is probably how it used to do it, but since transport objects
| already have a base, that is what Transport.clone() is meant to do.

Yes, it does it this way because this is how it was always done.  I
realized I needed the control_file api in Repository, so I factored it
out, and Robert suggested calling it LockableFiles.

I've been uncomfortable with the whole concept of Transports having
cwds.  In IRC, we discussed splitting Transport into ServerConnection
and DirectoryConnection, which would make me more comfortable, because
it would be easy to reuse ServerConnections.

Anyhow, until then, I'll agree it makes sense to reduce the number of
places we implement the concept of 'current working directory', so I'll
look at updating LockableFiles.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDsc0y0F+nu1YWqI0RAgR0AJoCx0mlH+nGKPIB+EXbwHCunpEv8QCfcnFt
LB2mWG4DmSj3M04K2AllVEk=
=GBk4
-----END PGP SIGNATURE-----