[RFC] bzr.jrydberg.versionedfile

[Johan Rydberg]

Robert Collins <robertc at robertcollins.net> writes:

>> But the fundamental reason I want the API to be generic is that the
>> identity map is just that; a generic way to cache information
>> throughout the lifetime of a transaction.  If you want to protect
>> yourself against collisions; use a more specific key.  In the case of
>> versioned files, only the store should know about the cached entries,
>> so it puts itself in the key.
>
> Sure, I'm not arguing about the key algorithm. I'm arguing against early
> generalisation. I think making it generic right now will prevent us
> seeing the real patterns that a set of explicit calls would show, and
> that that makes it less useful as a result. 

My opinion is that it is better to start with something generic, and
then make it more specific if there is a great need.  I do not see
that need right now.

~j