[RFC] bzr.jrydberg.versionedfile

[John Arbash Meinel]

Johan Rydberg wrote:
> John Arbash Meinel <john at arbash-meinel.com> writes:
> 
> 
>>>This is really a no-issue; but I like esthetics.  I can rewrite the
>>>code tens times if it doesn't look good. (and sometimes I just don't
>>>care for some reason.)  But open source is also about compromise.
>>>
>>>I'm +1 for *_text.
>>>
>>>~j
>>>
>>
>>I'm not sure what you mean by *_text. I think you mean "get_text()",
>>etc. Which I'm okay with, but what are they returning?
> 
> 
> Yes, sorry.  I'm just confused.  I mean: I'm +1 for get_text to return
> a list of lines, and add_text to get a list of lines.
> 
> ~j

Which is where I would like them to be "add_lines" and "get_lines".
And since it is a simple:
''.join(get_lines()), I don't think we really need the get_text
function, and add_lines(..., text.splitlines(True),) so we wouldn't
really need add_text.

Because text obviously has different interpretations, but *_lines seems
more obvious, I would lean in that direction.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051221/42bf7e37/attachment.pgp