[patch] Use /etc/mailname if available

[Jan Hudec]

On Tue, Dec 20, 2005 at 00:16:28 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> | I'm mostly in favour of this, but I'm not sure where Aarons sitting - I
> | haven't see a +- from him, but with his concerns I'd like to hear that
> | on this patch before offering +1 myself.
> 
> I don't see any harm in supporting /etc/mailname in the current regime,
> so don't let me stop you.
> 
> My concern is that I'm not sure whether autoselecting the email address
> is The Right Thing at all.  It may be better to prompt the user to
> supply a committer ID than to silently store a junk committer ID.

That sounds reasonable. It would require adding a function to the UIFactory,
but that's what it is there for after all. Something like get_text with the
same signature as get_password. The implementation in TextUIFactory could use
readline if available.

-- 
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051220/320291d8/attachment.pgp