bzr check

[Martin Pool]

On 16 Dec 2005, John Arbash Meinel <john at arbash-meinel.com> wrote:
> I went through the 'bzr check' code, and I notice it is doing this:
>         if rev.inventory_sha1:
>             inv_sha1 = branch.get_inventory_sha1(rev_id)
> However, branch.get_inventory_sha1 has been redefined as
> "get_revision().inventory_sha1"
> Which means that it is just regurgitating what was stored there. That
> doesn't seem quite right.

It might be better for the inventory to include the hash of a testament
of the revision, which would let us change the format while still
getting some assurance that the essential information is safe.

> The other thing it fails to do is to check that the hash in the weave
> toc matches the measured hash. It does make sure that get_file_lines()
> hash matches that of the inventory, which might be good enough.

It might be nice to just invoke the weave's own check routine for each
weave we see, and then trust that the hashes in the table-of-contents
are accurate.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051217/03d341ad/attachment.pgp