[RFC] [PATCH] (was: speeding up commits)
duchier at ps.uni-sb.de
duchier at ps.uni-sb.de
Thu Dec 15 10:47:49 GMT 2005
Robert Collins <robertc at robertcollins.net> writes:
> On Fri, 2005-12-09 at 22:29 +0100, duchier at ps.uni-sb.de wrote:
>
>> + def _find_previous_heads(self,ie):
>> +
>> + # information on predecessors and _previous_heads gets
>> + # cached only in the working tree inventory
>> +
>> + file_id = ie.file_id
>> + work_ie = self.work_inv[file_id]
>> +
>> + if work_ie._previous_heads is not None:
>> + return work_ie._previous_heads
>
> Hmm, I think there is some confusion here. previous heads and
> predecessors should be identical.
I think the confusion comes from the fact that there is code which
accepts predecessors either in the form of a list or in the form of a
dictionnary mapping revisions to inventory entries. That really
confused me for a while, but then I realized that it basically is
expecting a set. Right?
Cheers,
--Denys
More information about the bazaar
mailing list