[PATCH] fix for bzr rm -v

Robert Collins robertc at robertcollins.net
Thu Dec 15 04:12:08 GMT 2005


On Fri, 2005-12-09 at 19:41 +0100, Wouter van Heyst wrote:
> Attached is a testcase and oneline fix for 'bzr rm -v hello.txt' (as
> suggested in http://bazaar.canonical.com/IntroductionToBzr) failing
> because show_status is not known.
> 
> My first guess was to use bzrlib.status.show_status. Wrong idea,
> the code actually wants to use bzrlib.textui.show_status. Now, this does
> make it work again, but I'm not sure textui should be used from
> WorkingTree. What do others think?

Its' ok for WorkingTree to use the ui factory to access such things, but
not directly. This allows guis/other uis to replace the factory and
parameterise the entire code base for their environment easily.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051215/9b114f13/attachment.pgp 


More information about the bazaar mailing list