[PLUGIN] Updated tags plugin

Gustavo Niemeyer gustavo at niemeyer.net
Thu Dec 15 02:08:26 GMT 2005


Hello John,

[...]
> Also, I believe Niemeyer's changes were rather invasive, because of the
> pending-tags file, and commit-time semantics. (He had to be aware of
> both the tags weave, and also the current pending-tags, etc).

Having a pending-actions file and commit-time semantics is perhaps
not what you had in mind for the feature, but it doesn't mean
the change is invasive.

> I'm not sure which abstraction is worth breaking. I would kind of like
> to see a .bzr/tags file, which is revisioned as normal, but itself is
> just a plain file like .bzrignore. But that would mean that some files
[...]

That's similar to my original idea, but the truth is that I don't
have many specific desires for that feature. I just want to be able
to have a builtin map of name -> revision. At the time I wrote the
change, I talked to Aaron and Robert to see what they had in mind,
and tried to implement something close to that, so that it'd increase
the chances of some kind of tags support being adopted.

> Actually, now I think of it. I think Niemeyer introduced a
> "pending-actions" utility. Which some of those actions were
> add/delete/modify tags. Which was more generic, but I don't know what
> other ideas he had for pending-actions.

Like I mentioned at that time, pending-merges could very easily
get integrated.

> I do know that Niemeyer's changes were invasive enough that they won't
> apply on current bzr.dev. They need to be cleaned up first. But it
> might just be the best implementation we have so far.

Does it mean that you have a non-trivial patch from two months
ago that still apply? ;-)

-- 
Gustavo Niemeyer
http://niemeyer.net




More information about the bazaar mailing list