patch feedback - unicode in store names
Robert Collins
robertc at robertcollins.net
Thu Dec 15 02:00:46 GMT 2005
On Thu, 2005-12-08 at 18:11 +1100, Martin Pool wrote:
> >
> > This will ensure that all stores are accessed via unicode versions of
> > the name, and also happens to be a smaller diff ;).
>
> Alexander Belchenko's, I think. I'll change it as you suggest.
For folk reviewing (or changing :) code, a good heuristic to consider
is:
When you see similar changes made at many places, what can we do to
centralise those changes.
Thats the heuristic that raised a flag for me when I looked at that
merge.
Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051215/40fae99b/attachment.pgp
More information about the bazaar
mailing list