baz-import test requires 'testresources'

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Sure, but the mainline isn't really the official baz-import either, is
> it?

Yes, it is, until Robert says that his branch is mergeable.

> So what about the fact that you are already translating the '/' in arch
> revisions into %. Should that also be handled at the bzr encoding layer?

I would prefer if it was, yes.  Currently, '/' (and '\'?) are the only
forbidden characters in ids.

> Certainly bzrlib could urlencode things (so it would show up as %2F).
> 
> I think we should put in *some* sort of restrictions (for example,
> newline is a really bad id character, and '/' isn't all that nice
> either, control characters are also not wise).

Well, it's hard to say.  Advising against is one thing, but I believe
some Arch file-ids have newlines.

> So we can be a little flexible about what are standard is, and what we
> encode versus what other tools have to handle. But I don't think we want
> to switch and say "we will encode everything, you can give us any binary
> blob of bytes".

Actually, I would prefer if we used unicode ids, since your non-ascii
filenames could be used in bzr file-ids.

> Ultimately I don't care. Whether we encode them before writing them to
> disk, or we just disallow the characters. I just want filenames on
> Windows that work, so I can finally get rid of my Arch branches.
> I was actually thinking to just hack the bzrtools code to use 'Arch-'
> and just do a conversion (since it is likely to be a one time thing, or
> at least I'll be the only one doing the conversion).

I understand.  I would prefer if you used a character not used in
standard ids as the namespace separator, though, and it should have a
converter generation number (probably 2, since you're making a
significant change to the external behaviour of the converter).

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDnv0Q0F+nu1YWqI0RAtDfAJ4pJUSZHSMSzMwIJ3gR7YopvfjkJwCbBkTt
0tqHKis3Q4w65h0ojsZKMHQ=
=Pxra
-----END PGP SIGNATURE-----