[PATCH] default ID for gpg signing

[David Clymer]

On Sun, 2005-12-11 at 11:11 +1100, Robert Collins wrote:
> On Sat, 2005-12-10 at 11:00 -0500, David Clymer wrote:
> > On Sat, 2005-12-10 at 08:22 -0600, John Arbash Meinel wrote:
> > > David Clymer wrote:
> > > > For anyone with multiple gpg keys, the current gpg signing behavior may
> > > > not select the desired id. By default, this patch attempts to use the
> > > > key associated with the configured email address. If gpg_signing_id is
> > > > specified in the user config, that is used instead.
> > > > 
> > > > -davidc
> > > 
> > > +1 on having it configurable. But I don't see anywhere that:
> > > "attempts to use the key associated with the configured email address"
> > > 
> > > I would think you would need to "get_user_email" somewhere, and then ask
> > > gpg for the corresponding gpg id.
> > > 
> > 
> > I got the wrong diff, it seems. Correct one attached.
> 
> +1 on concept, -1 on a couple of small things:
> 
> The heuristic should be globally disableable - if my uid is just plain
> wrong but gpg is configured to use the right default, this heuristic
> will interfere - and force double-configuration. Perhaps setting the id
> explicitly to None or something (I don't know if config object
> discriminates between 'absent' and 'empty string'.) -0 to going in
> without this.
> 
> Secondly, this reduces the overall test coverage of bzr. -1 until there
> are minimally tests for the config value, and for the generated command
> line.

I think I've got these covered now.

The changes can be merged from:
    http://source.zettazebra.com/~vezult/dev/bzr.dc-gpg_id/


 1501 David Clymer      2005-12-11
      added configuration documentation for gpg_signing_id

 1500 David Clymer      2005-12-11
      add tests for bzr default gpg signing id

 1499 David Clymer      2005-12-11
      allow user to disable the fallback to user_email and just use the
default gpg id

 1498 David Clymer      2005-12-10
      use configured email as key id, if no gpg_signing_id is specified

 1497 David Clymer      2005-12-10
      allow signing with specific gpg keys

-davidc

-- 
gpg-key: http://www.zettazebra.com/files/key.gpg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051211/0a1ccecd/attachment.pgp