[PATCH] fix for bzr rm -v

John Arbash Meinel john at arbash-meinel.com
Sat Dec 10 01:56:32 GMT 2005


Wouter van Heyst wrote:
> Attached is a testcase and oneline fix for 'bzr rm -v hello.txt' (as
> suggested in http://bazaar.canonical.com/IntroductionToBzr) failing
> because show_status is not known.
> 
> My first guess was to use bzrlib.status.show_status. Wrong idea,
> the code actually wants to use bzrlib.textui.show_status. Now, this does
> make it work again, but I'm not sure textui should be used from
> WorkingTree. What do others think?
> 
> Wouter van Heyst
> 

+1
I agree that WorkingTree shouldn't depend on a text interface, but
show_status is actually just in a file with a bad name (ui/text.py is
the real text ui interface).

I'm not sure what file show_status should be in.
We could update the string work (check type, add a new suffix) into a
different function, and then update the ui functions to have a
"show_status" which can be abstracted behind the ui factory.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051209/402f7ed8/attachment.pgp 


More information about the bazaar mailing list