[PATCH] Re: any more sftp fixes?

[James Henstridge]

John A Meinel wrote:

>>The existing behaviour where self._port is None if no port was set in
>>the URL is intentional.  The _paramiko_connect() method should then
>>treat a port number of None as 22.  The current bzr.dev tree handles
>>this okay:
>>
>>            t = paramiko.Transport((self._host, self._port or 22))
>>
>>In the non-paramiko case, if the port is None then no port is specified
>>on the ssh command line.  Explicitly passing a port number will override
>>the setting in ~/.ssh/config (some people run an ssh server on an
>>alternative port for some services).
>>    
>>
>Yeah, I figured that out late. But this has been corrected.
>  
>
I haven't actually checked out your branch, but the working copy here
looks like it'll try to use a port number of None if using paramiko:
   
http://bzr.arbash-meinel.com/branches/bzr/jam-integration/bzrlib/transport/sftp.py

It is missing the "or 22" bit that is in bzr.dev.

James.