[PATCH] FTP transport

[Matthieu Moy]

Daniel Silverstone <dsilvers at digital-scurf.org> writes:

> I've written a patch which fixes a 'put' related issue and also covers
> this eventuality by seriously forcing one connection per
> host/user/pass/active four-tuple

Seems to work for me.

I still have a problem with my provider: It's closing the connection
periodically (that's a known problem with this ISP), so bzr stops with

bzr: ERROR: ftplib.error_temp: 425 Can't open data connection.
  at /usr/lib/python2.4/ftplib.py line 212
  in getresp

and I have to re-run it several times up to completion. It would be
great if bzr could try to reconnect when an operation fails (many ftp
clients do this seamlessly). I don't know whether this should be in
transport of ftp.

> Yeah. The other issue is that even after it completes successfully, only
> the .bzr dir will be populated, it won't be a working tree of any
> usefulness, but it works fine for merge/branch

Yes, but that's bzr push's behavior, not the transport layer.

-- 
Matthieu